Add modification caching; Constant terminal mods for ProForma #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Modification caching** All ModificationResolver types now use an in-memory cache for resolved modification definitions, reducing overhead of resolving the same rule over and over again. Sub-classes should move their implementation of `resolve` to the `_resolve_impl` method, otherwise the cache will not be used. To disable the cache for a resolver instance, call `resolver.enable_caching(False)`. **Constant terminal modifications** This implements support for the syntax discussed in HUPO-PSI/ProForma#6 to include constant modification rules that apply to specific sequence terminals with or without specific amino acids.
mobiusklein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification caching
All ModificationResolver types now use an in-memory cache for resolved modification definitions, reducing overhead of resolving the same rule over and over again.
Sub-classes should move their implementation of
resolveto the_resolve_implmethod, otherwise the cache will not be used.To disable the cache for a resolver instance, call
resolver.enable_caching(False).Constant terminal modifications
This implements support for the syntax discussed in HUPO-PSI/ProForma#6 to include constant modification rules that apply to specific sequence terminals with or without specific amino acids.